[ 
https://issues.apache.org/jira/browse/SOLR-3040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Smiley closed SOLR-3040.
------------------------------

       Resolution: Fixed
    Fix Version/s: 4.0
                   3.6
         Assignee: David Smiley

Committed branch_3x: r1293105 trunk: r1293102

CHANGES.txt entry underneath upgrade instructions:
{noformat}
* SOLR-3040: The DIH's admin UI (dataimport.jsp) now requires
 DIH request handlers to start with a '/'. (dsmiley)
{noformat}


FYI it turned out that in the span of time since when I did the first patch and 
when I committed now, the new admin UI already gained this limitation (leading 
'/' required).  Wether deliberate or accidental, I'm glad.
                
> Avoid use of qt param for the DIH in the admin UI
> -------------------------------------------------
>
>                 Key: SOLR-3040
>                 URL: https://issues.apache.org/jira/browse/SOLR-3040
>             Project: Solr
>          Issue Type: Improvement
>          Components: web gui
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Minor
>             Fix For: 3.6, 4.0
>
>         Attachments: SOLR-3040_avoid_qt_for_DIH_in_admin_ui.patch
>
>
> I really, really dislike that the qt parameter can used to refer to request 
> handlers starting with a '/', _especially_ for non-search handlers.  The 
> admin UI has one place I am aware of that attempts to do this, which is the 
> DIH's admin page.  Since we have two UIs in trunk, the new and old, there are 
> actually two UIs where this occurs, and the old UI has two related files that 
> need updating, in order to address this issue.
> An example URL generated by the UI today is this:
>   http://localhost:8983/solr/rss/select?qt=/dataimport&command=show-config
> And here it is without using qt:
>   http://localhost:8983/solr/rss/dataimport?command=show-config
> I do realize that fixing this issue as I do in my patch will make the UI not 
> work if the DIH isn't registered with a leading '/', but honestly I wonder 
> who if anyone out there does that.  And even then, it's easily rectified.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to