TermOrdVal/DocValuesComparator does too much work in compareBottom ------------------------------------------------------------------
Key: LUCENE-3824 URL: https://issues.apache.org/jira/browse/LUCENE-3824 Project: Lucene - Java Issue Type: Improvement Reporter: Michael McCandless Assignee: Michael McCandless Priority: Minor Fix For: 3.6, 4.0 We now have logic to fall back to by-value comparison, when the bottom slot is not from the current reader. But this is silly, because if the bottom slot is from a different reader, it means the tie-break case is not possible (since the current reader didn't have the bottom value), so when the incoming ord equals the bottom ord we should always return x > 0. I added a new random string sort test case to TestSort... I also renamed DocValues.SortedSource.getByValue -> getOrdByValue and cleaned up some whitespace. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org