[ https://issues.apache.org/jira/browse/SOLR-2719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222394#comment-13222394 ]
Luca Cavanna commented on SOLR-2719: ------------------------------------ Yonik, I see your point. On the other hand, the dash is a widely used character within field names. The regression is on the Solr behaviour, and I think it's pretty annoying from a user perspective. Anyway, if that's the direction of the project, no problem. What matters more than anything else is consistency. We should document it somewhere as you wrote, but I'd also propose a field names validation at Solr startup, using the StrParser rules, so that Solr accepts only allowed field names and can guarantee the proper behaviour with all allowed field names. What do you think? > REGRESSION ReturnFields incorrect parse fields with hyphen - breaks existing > "fl=my-field-name" type usecases > ------------------------------------------------------------------------------------------------------------- > > Key: SOLR-2719 > URL: https://issues.apache.org/jira/browse/SOLR-2719 > Project: Solr > Issue Type: Bug > Components: search > Affects Versions: 4.0 > Reporter: Nik V. Babichev > Priority: Blocker > Labels: field, fl, query, queryparser > Fix For: 4.0 > > Attachments: SOLR-2719.patch > > > fl=my-hyphen-field in query params parsed as "my" instead of > "my-hyphen-field". > OAS.search.ReturnFields use method getId() from OAS.search.QueryParsing > in which check chars "if (!Character.isJavaIdentifierPart(ch) && ch != '.')" > Hyphen is not JavaIdentifierPart and this check break when first "-" is found. > This problem solve by passing '-' to check: > if (!Character.isJavaIdentifierPart(ch) && ch != '.' && ch != '-') break; > But I don't know how it can affect on whole project. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org