[ https://issues.apache.org/jira/browse/SOLR-2719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Luca Cavanna updated SOLR-2719: ------------------------------- Attachment: SOLR-2719.patch Right Yonik, I've been misled by the {code} String field = sp.getId(null); {code} at the beginning of QueryParsing#parseSort, while the method to look at was getSimpleName. Sorting is ok (but I don't completely understand the sp.getId at the beginning). I attached a new patch: I added to StrParser a getFieldName method and added to getId the possibility to pass a vararg parameter of allowed trailing chars. I made also some changes to ReturnFields to make the code a little bit more readable to me, hope is the same for you guys. Tests work. I removed the weird tests about trailing tilde and so on, kept just the trailing dash test which now works (removed @Ignore). Let me know what you think. I'm going to open a new issue to add field names validation. > REGRESSION ReturnFields incorrect parse fields with hyphen - breaks existing > "fl=my-field-name" type usecases > ------------------------------------------------------------------------------------------------------------- > > Key: SOLR-2719 > URL: https://issues.apache.org/jira/browse/SOLR-2719 > Project: Solr > Issue Type: Bug > Components: search > Affects Versions: 4.0 > Reporter: Nik V. Babichev > Priority: Blocker > Labels: field, fl, query, queryparser > Fix For: 4.0 > > Attachments: SOLR-2719.patch, SOLR-2719.patch > > > fl=my-hyphen-field in query params parsed as "my" instead of > "my-hyphen-field". > OAS.search.ReturnFields use method getId() from OAS.search.QueryParsing > in which check chars "if (!Character.isJavaIdentifierPart(ch) && ch != '.')" > Hyphen is not JavaIdentifierPart and this check break when first "-" is found. > This problem solve by passing '-' to check: > if (!Character.isJavaIdentifierPart(ch) && ch != '.' && ch != '-') break; > But I don't know how it can affect on whole project. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org