[ https://issues.apache.org/jira/browse/LUCENE-3767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224025#comment-13224025 ]
Christian Moen commented on LUCENE-3767: ---------------------------------------- I've attached a patch for {{branch_3x}} and I'd be very thankful if Robert or Mike could have a quick look before I commit. These are some comments and questions: # I haven't backported the test for {{PositionLengthAttribute}} since the structure seems very different in {{branch_3x}}. Perhaps this is something we could look to as we start using PositionLength in more of the other analyzers? # There will be some minor discrepancies between {{trunk}} and {{branch_3x}} with regards to {{Set<?>}} and {{CharArraySet}} types. Perhaps we should use {{CharArraySet}} on across the board here in the future? # Does the {{svn:mergeinfo}} look okay in the patch? Tests pass on {{branch_3x}} and I've verified that the new feature seems fine in a Solr build as well. > Explore streaming Viterbi search in Kuromoji > -------------------------------------------- > > Key: LUCENE-3767 > URL: https://issues.apache.org/jira/browse/LUCENE-3767 > Project: Lucene - Java > Issue Type: Improvement > Components: modules/analysis > Reporter: Michael McCandless > Assignee: Christian Moen > Fix For: 3.6, 4.0 > > Attachments: LUCENE-3767.patch, LUCENE-3767.patch, LUCENE-3767.patch, > LUCENE-3767.patch, LUCENE-3767.patch, LUCENE-3767_branch_3x.patch, > SolrXml-5498.xml, compound_diffs.txt > > > I've been playing with the idea of changing the Kuromoji viterbi > search to be 2 passes (intersect, backtrace) instead of 4 passes > (break into sentences, intersect, score, backtrace)... this is very > much a work in progress, so I'm just getting my current state up. > It's got tons of nocommits, doesn't properly handle the user dict nor > extended modes yet, etc. > One thing I'm playing with is to add a double backtrace for the long > compound tokens, ie, instead of penalizing these tokens so that > shorter tokens are picked, leave the scores unchanged but on backtrace > take that penalty and use it as a threshold for a 2nd best > segmentation... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org