[ 
https://issues.apache.org/jira/browse/SOLR-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224116#comment-13224116
 ] 

Emmanuel Bourg commented on SOLR-3204:
--------------------------------------

Your analysis is correct Ryan. Anyone building upon the Solr code is affected 
by this issue. The fact the offending artifacts are in the central Maven 
repository only makes the problem worse, 

I discovered this issue because someone who imported solr-commons-csv in its 
project reported an issue (SANDBOX-330), an infinite loop with trailing 
comments, that was already fixed on the trunk. I didn't know about the 
solr-commons-csv artifact in the central Maven repository until then. So I 
inspected the jar and gasped in awe at the unmodified namespace.

I understand that Maven as a build tool is controversial, I'm myself an heavy 
Ant user on several projects requiring complex build setups. But Maven, as a 
way to share code through a central repository, is also a very valuable tool. 
It's adopted by alternative build tools like Ivy and Gradle. It's also used by 
IDEs to import dependencies automatically and to be able to browse their source 
and Javadoc easily. It's difficult to understand why this part is also hated by 
Maven detractors. The constraints on the central repository aren't that 
unbearable, the most important rule to follow is to not publish two artifacts 
identified by distinct groupId:artifactId with conflicting classes. The 
corollary is that a project A should not publish classes in the namespace of a 
project B.

                
> solr-commons-csv must not use the org.apache.commons.csv package
> ----------------------------------------------------------------
>
>                 Key: SOLR-3204
>                 URL: https://issues.apache.org/jira/browse/SOLR-3204
>             Project: Solr
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 3.5
>            Reporter: Emmanuel Bourg
>            Priority: Blocker
>             Fix For: 3.6
>
>         Attachments: SOLR-3204.patch, solr-csv.patch
>
>
> The solr-commons-csv artifact reused the code from the Apache Commons CSV 
> project but the package wasn't changed to something else than 
> org.apache.commons.csv in the process. This creates a compatibility issue as 
> the Apache Commons team works toward an official release of Commons CSV. It 
> prevents Commons CSV from using its own org.apache.commons.csv package, or 
> forces the renaming of all the classes to avoid a classpath conflict.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to