[ 
https://issues.apache.org/jira/browse/SOLR-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224482#comment-13224482
 ] 

Uwe Schindler edited comment on SOLR-3204 at 3/7/12 4:36 PM:
-------------------------------------------------------------

Here the patch and the transformed JAR file (and renamed). Most of the patch is 
my rename of the JAR file to solr- prefix. Code changes is 5 lines of import 
statements!

What I did:
- copy the original JAR file to a folder
- place jarjar-1.2.jar somewhere
- edit the rules.txt file and change package names
- run java -jar jarjar-1.2.jar process rule.txt 
commons-csv-1.0-SNAPSHOT-r966014.jar solr-commons-csv-1.0-SNAPSHOT-r966014.jar
- place the resulting jar file in solr/core/lib (remove the old one before) and 
commit it like any other bundled artifact :-)

All tests pass and the supplied JAR file could be published in maven with the 
name sarowe gave it.
                
      was (Author: thetaphi):
    Here the patch and the transformed JAR file (and renamed).

What I did:
- copy the original JAR file to a folder
- place jarjar-1.2.jar somewhere
- edit the rules.txt file and change package names
- run java -jar jarjar-1.2.jar process rule.txt 
commons-csv-1.0-SNAPSHOT-r966014.jar solr-commons-csv-1.0-SNAPSHOT-r966014.jar

All tests pass and the supplied JAR file could be published in maven with the 
name sarowe gave it.
                  
> solr-commons-csv must not use the org.apache.commons.csv package
> ----------------------------------------------------------------
>
>                 Key: SOLR-3204
>                 URL: https://issues.apache.org/jira/browse/SOLR-3204
>             Project: Solr
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 3.5
>            Reporter: Emmanuel Bourg
>            Priority: Blocker
>             Fix For: 3.6
>
>         Attachments: SOLR-3204.patch, SOLR-3204.patch, rule.txt, 
> solr-commons-csv-1.0-SNAPSHOT-r966014.jar, solr-csv.patch
>
>
> The solr-commons-csv artifact reused the code from the Apache Commons CSV 
> project but the package wasn't changed to something else than 
> org.apache.commons.csv in the process. This creates a compatibility issue as 
> the Apache Commons team works toward an official release of Commons CSV. It 
> prevents Commons CSV from using its own org.apache.commons.csv package, or 
> forces the renaming of all the classes to avoid a classpath conflict.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to