+1, thanks Dawid. -----Original Message----- From: [email protected] [mailto:[email protected]] Sent: Thursday, March 08, 2012 2:58 AM To: [email protected] Subject: svn commit: r1298287 - in /lucene/dev/trunk: lucene/common-build.xml modules/grouping/src/test/org/apache/lucene/search/grouping/AbstractGroupingTestCase.java
Author: dweiss Date: Thu Mar 8 07:57:51 2012 New Revision: 1298287 URL: http://svn.apache.org/viewvc?rev=1298287&view=rev Log: Steve: this should be a better solution than @Ignore? Maven won't run abstract classes and this seems more consistent with the declared class purpose... Modified: lucene/dev/trunk/lucene/common-build.xml lucene/dev/trunk/modules/grouping/src/test/org/apache/lucene/search/grouping/AbstractGroupingTestCase.java Modified: lucene/dev/trunk/lucene/common-build.xml URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/common-build.xml?rev=1298287&r1=1298286&r2=1298287&view=diff ============================================================================== --- lucene/dev/trunk/lucene/common-build.xml (original) +++ lucene/dev/trunk/lucene/common-build.xml Thu Mar 8 07:57:51 2012 @@ -170,7 +170,7 @@ <property name="junit.output.dir.backwards" location="${build.dir.backwards}/test"/> <property name="junit.reports" location="${build.dir}/test/reports"/> <property name="junit.reports.backwards" location="${build.dir.backwards}/test/reports"/> - <property name="junit.excludes" value=""/> + <property name="junit.excludes" value="**/Abstract*"/> <condition property="junit.details.formatter" value="org.apache.tools.ant.taskdefs.optional.junit.BriefJUnitResultFormatter" else="org.apache.lucene.util.LuceneJUnitResultFormatter"> Modified: lucene/dev/trunk/modules/grouping/src/test/org/apache/lucene/search/grouping/AbstractGroupingTestCase.java URL: http://svn.apache.org/viewvc/lucene/dev/trunk/modules/grouping/src/test/org/apache/lucene/search/grouping/AbstractGroupingTestCase.java?rev=1298287&r1=1298286&r2=1298287&view=diff ============================================================================== --- lucene/dev/trunk/modules/grouping/src/test/org/apache/lucene/search/grouping/AbstractGroupingTestCase.java (original) +++ lucene/dev/trunk/modules/grouping/src/test/org/apache/lucene/search/ +++ grouping/AbstractGroupingTestCase.java Thu Mar 8 07:57:51 2012 @@ -17,30 +17,14 @@ package org.apache.lucene.search.groupin * limitations under the License. */ -import org.apache.lucene.document.Field; -import org.apache.lucene.document.FieldType; -import org.apache.lucene.search.Sort; -import org.apache.lucene.search.SortField; -import org.apache.lucene.util.BytesRef; import org.apache.lucene.util.LuceneTestCase; import org.apache.lucene.util._TestUtil; -import org.junit.Ignore; - -import java.util.ArrayList; -import java.util.Comparator; -import java.util.List; -import java.util.Random; - -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.fail; /** * Base class for grouping related tests. */ // TODO (MvG) : The grouping tests contain a lot of code duplication. Try to move the common code to this class.. -@Ignore("Maven Surefire will attempt to run this test suite without an @Ignore annotation.") -public class AbstractGroupingTestCase extends LuceneTestCase { - +public abstract class AbstractGroupingTestCase extends LuceneTestCase { protected String generateRandomNonEmptyString() { String randomValue; do { @@ -50,5 +34,4 @@ public class AbstractGroupingTestCase ex } while ("".equals(randomValue)); return randomValue; } - }
