[ 
https://issues.apache.org/jira/browse/SOLR-3011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226934#comment-13226934
 ] 

Mikhail Khludnev commented on SOLR-3011:
----------------------------------------

Ok. I've got what the problem is. But it's much more complicate than I could 
imagine. MockDataSource which is used for cover all DIH stores an iterators, 
not a collections as a resultsets. So, you retrieve such result set as an 
iterator, exhaust it, than you can retrieve the same exhausted resultset again 
and get that it's empty. That's not a case for the real SQL datasource, it 
works as a collection: every time you get the brand new resultset. After I 
amend MockDataSource to provide collections, most of tests fail. As far as I 
understand your particular fix doesn't work for parent-child case. I'm on the 
long road for providing a fix. 

Thanks for spotting it. It's absolutely useful.
                
> DIH MultiThreaded bug
> ---------------------
>
>                 Key: SOLR-3011
>                 URL: https://issues.apache.org/jira/browse/SOLR-3011
>             Project: Solr
>          Issue Type: Sub-task
>          Components: contrib - DataImportHandler
>    Affects Versions: 3.5, 4.0
>            Reporter: Mikhail Khludnev
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: SOLR-3011.patch, SOLR-3011.patch, 
> patch-3011-EntityProcessorBase-iterator.patch
>
>
> current DIH design is not thread safe. see last comments at SOLR-2382 and 
> SOLR-2947. I'm going to provide the patch makes DIH core threadsafe. Mostly 
> it's a SOLR-2947 patch from 28th Dec. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to