[ 
https://issues.apache.org/jira/browse/SOLR-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227284#comment-13227284
 ] 

Andrew Morrison commented on SOLR-3218:
---------------------------------------

The latest patch is updated to account for the CurrencyField name.

I updated CurrencyValue.toString() to return "3.14,USD" for $3.14 rather than 
"314,USD". My feeling is that it's more straight forward to return strings that 
look like the values that were passed in to parse(). If we don't want toString 
to act as such, I can move that logic to 
CurrencyRangeEndpointCalculator.formatValue(). Also of interest, I'm injecting 
a '.' into the toString value of the long amount rather than using any existing 
floating point number formatters which might use a ',' rather than a '.' 
causing issues with the existing comma delimiter between the amount and 
currencyCode.

Hoss,

It was easy to allow the gap to be in any currency for which we have a 
conversion, so we're now allowing that. Start and end must still be of the same 
currency. I worry that relaxing the restriction on the gap may just be 
confusing without adding any real value. We may want to consider forcing gap to 
be the same as start and end so that things are more conceptually straight 
forward.
                
> Range faceting support for CurrencyField
> ----------------------------------------
>
>                 Key: SOLR-3218
>                 URL: https://issues.apache.org/jira/browse/SOLR-3218
>             Project: Solr
>          Issue Type: Improvement
>          Components: Schema and Analysis
>            Reporter: Jan Høydahl
>             Fix For: 4.0
>
>         Attachments: SOLR-3218-1.patch, SOLR-3218-2.patch, SOLR-3218.patch
>
>
> Spinoff from SOLR-2202. Need to add range faceting capabilities for 
> CurrencyField

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to