[
https://issues.apache.org/jira/browse/SOLR-3241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229298#comment-13229298
]
Hoss Man commented on SOLR-3241:
--------------------------------
patch looks fine ... i wish there was a way to make it easier for poly fields
so they wouldn't have do do the check themselves, but when i tried the idea i
had it didn't work, so better to go with this for now and maybe refactor a
helper method later.
the few changes i would make:
1) make the new tests grab the IndexSchema obejct and assert that every field
(that the cares about) has the expected omitNorms value -- future proof
ourselves against someone nuetering the test w/o realizing by tweaking the test
schema because they don't know that there is a specific reason for those
omitNorm settings
2) add a test that explicitly verifies the failure case of someone setting
field boost on a field with omitNorms==true, assert that we get the expected
error mesg (doesn't look like this was added when LUCENE-3796 was commited, and
we want to make sure we don't inadvertantly break that error check)
> Document boost fail if a field copy omit the norms
> --------------------------------------------------
>
> Key: SOLR-3241
> URL: https://issues.apache.org/jira/browse/SOLR-3241
> Project: Solr
> Issue Type: Bug
> Reporter: Tomás Fernández Löbbe
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-3241.patch, SOLR-3241.patch, SOLR-3241.patch,
> SOLR-3241.patch
>
>
> After https://issues.apache.org/jira/browse/LUCENE-3796, it is not possible
> to set a boost to a field that has the "omitNorms" set to true. This is
> making Solr's document index-time boost to fail when a field that doesn't
> omit norms is copied (with copyField) to a field that does omit them and
> document boost is used. For example:
> <field name="author" type="text" indexed="true" stored="false"
> omitNorms="false"/>
> <field name="author_display" type="string" indexed="true" stored="true"
> omitNorms="true"/>
> <copyField source="author" dest="author_display"/>
> I'm attaching a possible fix.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
