[
https://issues.apache.org/jira/browse/SOLR-3011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Khludnev updated SOLR-3011:
-----------------------------------
Attachment: SOLR-3011.patch
OK. next attempt.
Core point is cover case shed by Petr: requerying a datasource. I amended
MockDatasource to use collection intead of extraditable iterators. It reveals
two things: incorrect entityEnded flag - I killed it. Also cache and
entityProcessor has wrong two statelogic: non-init/init. I implemented more
correct three sate FSM: non-init, iterating, eof. Also I had to push code from
ThreadedEPW into plain EPW. AFAIK overhead from redundant synchronize is
misarable.
delta between patches for fast review
https://github.com/m-khl/solr-patches/commit/eb49a0024fc6e48d5d19fd784161fc7d331a3150
Petr, can't you check that it works. You can take the applied patch from
https://github.com/m-khl/solr-patches/tree/solr3011
> DIH MultiThreaded bug
> ---------------------
>
> Key: SOLR-3011
> URL: https://issues.apache.org/jira/browse/SOLR-3011
> Project: Solr
> Issue Type: Sub-task
> Components: contrib - DataImportHandler
> Affects Versions: 3.5, 4.0
> Reporter: Mikhail Khludnev
> Priority: Minor
> Fix For: 4.0
>
> Attachments: SOLR-3011.patch, SOLR-3011.patch, SOLR-3011.patch,
> patch-3011-EntityProcessorBase-iterator.patch,
> patch-3011-EntityProcessorBase-iterator.patch
>
>
> current DIH design is not thread safe. see last comments at SOLR-2382 and
> SOLR-2947. I'm going to provide the patch makes DIH core threadsafe. Mostly
> it's a SOLR-2947 patch from 28th Dec.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
