[
https://issues.apache.org/jira/browse/LUCENE-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234556#comment-13234556
]
Michael McCandless commented on LUCENE-2788:
--------------------------------------------
+1
I really like the approach here (just using FilterReader instead of our own new
class).
Since the back-compat is going be tricky... maybe we should first commit this
patch to trunk?
> Make CharFilter reusable
> ------------------------
>
> Key: LUCENE-2788
> URL: https://issues.apache.org/jira/browse/LUCENE-2788
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/analysis
> Reporter: Robert Muir
> Priority: Minor
> Attachments: LUCENE-2788.patch
>
>
> The CharFilter API lets you wrap a Reader, altering the contents before the
> Tokenizer sees them.
> It also allows you to correct the offsets so this is transparent to
> highlighting.
> One problem is that the API isn't reusable, if you have a lot of short
> documents its going to be efficient.
> Additionally there is some unnecessary wrapping in Tokenizer (see the
> CharReader.get in the ctor, but *not* in reset(Reader)!!!)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
