[
https://issues.apache.org/jira/browse/SOLR-435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-435:
------------------------------
Attachment: SOLR-435_q_defaults_to_all-docs.patch
Attached is a patch that I'd like to apply on Monday end of day (EST). My
changes.txt is as follows:
* SOLR-435: For the lucene, dismax, and edismax query parsers: if no query
string is supplied, or if its blank or just whitespace, then the default is to
match all documents. It used to be an error. This basically means 'q' isn't
required and q.alt=*:* is redundant. (dsmiley)
I also discovered and fixed a bug in edismax in which a query of pure
whitespace threw an error. dismax didn't do this. It was a trivial fix in which
a trim() was forgotten.
There are many ways to approach addressing this issue with different pros/cons;
it was hard to ultimately settle on what I chose to do. I could have modified
QueryComponent, or just QParser, or just the actual QParser subclasses. A
universal choice couldn't be made for all qparsers because most qparsers don't
even use the query string. Feedback please!
> QParser must validate existance/absense of "q" parameter
> --------------------------------------------------------
>
> Key: SOLR-435
> URL: https://issues.apache.org/jira/browse/SOLR-435
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3
> Reporter: Ryan McKinley
> Assignee: Ryan McKinley
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-435_q_defaults_to_all-docs.patch
>
>
> Each QParser should check if "q" exists or not. For some it will be required
> others not.
> currently it throws a null pointer:
> {code}
> java.lang.NullPointerException
> at org.apache.solr.common.util.StrUtils.splitSmart(StrUtils.java:36)
> at
> org.apache.solr.search.OldLuceneQParser.parse(LuceneQParserPlugin.java:104)
> at org.apache.solr.search.QParser.getQuery(QParser.java:80)
> at
> org.apache.solr.handler.component.QueryComponent.prepare(QueryComponent.java:67)
> at
> org.apache.solr.handler.SearchHandler.handleRequestBody(SearchHandler.java:150)
> ...
> {code}
> see:
> http://www.nabble.com/query-parsing-error-to14124285.html#a14140108
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
