[ 
https://issues.apache.org/jira/browse/LUCENE-3919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238001#comment-13238001
 ] 

Uwe Schindler commented on LUCENE-3919:
---------------------------------------

Please don't commit... I will take care :-) - tomorrow!

There should be also improvements in ctor detectors: all 
Tokenizers/Tokenfilters with matchVersion will not work, I will think about 
some more intelligent ctor parsing: Class.getConstructors() -> choose one which 
has at least a Reader/TokenStream param, if a version is also there fill in 
matchVersion and all other parameters maybe random (int, bool,...)? Random 
params should always produce something correct, or they should throw 
IllegalArgumentException/... on the ctor.
                
> more thorough testing of analysis chains
> ----------------------------------------
>
>                 Key: LUCENE-3919
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3919
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: modules/analysis
>    Affects Versions: 3.6, 4.0
>            Reporter: Robert Muir
>         Attachments: LUCENE-3919.patch
>
>
> In lucene we essentially test each analysis component separately. we also 
> give some
> good testing to the example Analyzers we provide that combine them.
> But we don't test various combinations that are possible: which is bad because
> it doesnt test possibilities for custom analyzers (especially since lots of 
> solr users
> etc define their own).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to