[ 
https://issues.apache.org/jira/browse/LUCENE-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244019#comment-13244019
 ] 

Chris Male edited comment on LUCENE-3930 at 4/2/12 7:25 AM:
------------------------------------------------------------

Thanks for the review.

bq. 1) sourceDirectory and testSourceDirectory look like default values anyway?

Err.. yes, I used the pom the maintainer had started and forgot to pull those 
out.  Will do.

bq. 2) there is a newer version of jsonic in maven repositories; don't know if 
this matters at all.

I will stick with the version used in the project.
                
      was (Author: cmale):
    bq. 1) sourceDirectory and testSourceDirectory look like default values 
anyway?

Err.. yes, I used the pom the maintainer had started and forgot to pull those 
out.  Will do.

bq. 2) there is a newer version of jsonic in maven repositories; don't know if 
this matters at all.

I will stick with the version used in the project.
                  
> nuke jars from source tree and use ivy
> --------------------------------------
>
>                 Key: LUCENE-3930
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3930
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: general/build
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>            Priority: Blocker
>             Fix For: 3.6
>
>         Attachments: LUCENE-3930-skip-sources-javadoc.patch, 
> LUCENE-3930-solr-example.patch, LUCENE-3930-solr-example.patch, 
> LUCENE-3930.patch, LUCENE-3930.patch, LUCENE-3930.patch, 
> LUCENE-3930__ivy_bootstrap_target.patch, 
> LUCENE-3930_includetestlibs_excludeexamplexml.patch, 
> ant_-verbose_clean_test.out.txt, noggit-commons-csv.patch, 
> patch-jetty-build.patch, pom.xml
>
>
> As mentioned on the ML thread: "switch jars to ivy mechanism?".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to