[ 
https://issues.apache.org/jira/browse/LUCENE-3951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246426#comment-13246426
 ] 

Steven Rowe commented on LUCENE-3951:
-------------------------------------

{quote}
bq. 'The maven build' doesn't require generate-maven-artifacts, and never has.

well at least hudson needs to call the logic in my patch (somehow) because the 
maven bootstrap uses:

{noformat}<file>solr/example/lib/jetty-${patched.jetty.version}.jar</file>{noformat}
{quote}

Your patch puts {{ant resolve}} in the wrong place.

{{mvn -P bootstrap install}} is run by the jenkins script before attempting to 
run {{mvn install}} and {{mvn test}},  but {{ant genenerate-maven-artifacts}} 
is called by the jenkins script *after* running all of these (to deploy 
snapshots), so {{ant resolve}} should happen *before* any of the {{mvn ...}} 
stuff.

{quote}
And it seems that maven could do this itself in its executions?
see 
http://search.maven.org/remotecontent?filepath=org/apache/rat/apache-rat-tasks/0.8/apache-rat-tasks-0.8.pom
 for an example?
{quote}

Yes, you're right - the ant build shouldn't have to deal with this at all.  
I'll make a patch.
                
> get-maven-poms should depend on ivy resolve, so that non-mavenized jars are 
> available for use by mvn -P bootstrap install
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3951
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3951
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: general/build
>    Affects Versions: 3.6
>            Reporter: Steven Rowe
>            Assignee: Steven Rowe
>             Fix For: 3.6
>
>         Attachments: LUCENE-3951.patch
>
>
> see title

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to