[ 
https://issues.apache.org/jira/browse/SOLR-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248561#comment-13248561
 ] 

Uwe Schindler edited comment on SOLR-3328 at 4/6/12 6:16 PM:
-------------------------------------------------------------

Yes, it also works for ZIP.

I checked Solr's build.xml: It already does what I propose (haveing several 
tarfilesets and zipfilesets). But it looks like it only sets mode to 755 for 
example/**.sh, not globally.

So the fix is to extend that to include *all* .sh files (just change some 
properties).

I checked both that TGZ and ZIP files for 3.x, too - they have (partly) 
incorrect attributes (binary tgz is correct, it has +x on example post.sh), so 
something is wrong with the src filesets (I think they are outdated as they 
dont respect the root). The files in scripts have no *.sh extension but are 
still shell scripts. Those have no 755, too.

I will look into this and provide patch fro trunk. 3.x is too late.
                
      was (Author: thetaphi):
    Yes, it also works for ZIP.

I checked Solr's build.xml: It already does what I propose (haveing several 
tarfilesets and zipfilesets). But it looks like it only sets mode to 755 for 
example/**.sh, not globally.

So the fix is to extend that to include *all* .sh files (just change some 
properties).

I checked both that TGZ and ZIP files for 3.x, too - they have incorrect 
attributes, so something is wrong with the filesets (I think they are outdated 
as they dont respect the root). The files in scripts have no *.sh extension but 
are still shell scripts. Those have no 755, too.

I will look into this and provide patch fro trunk. 3.x is too late.
                  
> executable bits of shellscripts in solr source release
> ------------------------------------------------------
>
>                 Key: SOLR-3328
>                 URL: https://issues.apache.org/jira/browse/SOLR-3328
>             Project: Solr
>          Issue Type: Improvement
>          Components: Build
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>
> HossmanSays: in the solr src releases, some shell scripts are not executable 
> by default.
> I don't know if we can improve this? Maybe its an svn prop?
> Maybe something needs to be specified to the tar/zip process?
> Currently the 'source release' is really an svn export...
> Personally i always do 'sh foo.sh' rather than './foo.sh',
> but if it makes it more user-friendly we should figure it out
> Just opening the issue since we don't forget about it, I think solr cloud
> adds some more shell scripts so we should at least figure out what we want to 
> do.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to