[
https://issues.apache.org/jira/browse/LUCENE-3969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-3969:
----------------------------------
Attachment: LUCENE-3969.patch
New patch with the Constructors moved up the chain to be top-level citizens,
analysis classes are no longer explicitely used.
It would be goot to fix the randomParameter generator to never fail but instead
the reflection code in beforClass() to check the constructor args against a
Set<Class<?>> validArgs of valid parameters and throw away all invalid ctors
from the beginning:
validArgs.containsAll(Arrays.asList(ctor.getParameterTypes()))
> Use all (non-deprecated) analysis ctors in TestRandomChains
> -----------------------------------------------------------
>
> Key: LUCENE-3969
> URL: https://issues.apache.org/jira/browse/LUCENE-3969
> Project: Lucene - Java
> Issue Type: Bug
> Components: modules/analysis
> Reporter: Robert Muir
> Attachments: LUCENE-3969.patch, LUCENE-3969.patch, LUCENE-3969.patch,
> LUCENE-3969.patch, LUCENE-3969.patch
>
>
> We made TestRandomChains in LUCENE-3919, which reflects all
> analysis components from the classpath and builds analyzers from them,
> then checks consistency.
> but currently it only supports some tokenizers/tokenfilters/charfilters,
> because it hardcodes at certain ctors e.g. Tokenizer(Reader) and
> Tokenizer(Version+Reader).
> Instead we should use all ctors, just filling them in with random data of
> whatever argument type they take.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
