[ 
https://issues.apache.org/jira/browse/LUCENE-3965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255520#comment-13255520
 ] 

Steven Rowe commented on LUCENE-3965:
-------------------------------------

+1 to commit - good progress!

Tests work from the top level, and I tried {{ant test}} in a couple of modules' 
directories, which also worked.  Build output all seems to be going to the 
right place (under {{lucene/build/}}).

I scanned the changed build files, and I didn't see any problems.

I searched {{\*build.xml}} for "modules/" and "contrib".  "modules/" seems to 
be gone, but there are several names that still have "contrib" in them (e.g. 
{{test-contrib}}) in {{lucene/build.xml}} and {{lucene/common-build.xml}}.  
These names can be fixed later.

I didn't look at javadocs or packaging - I assume anything you've done there 
will be better than it was :).
                
> consolidate all api modules in one place and un!@$# packaging for 4.0
> ---------------------------------------------------------------------
>
>                 Key: LUCENE-3965
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3965
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: general/build
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>         Attachments: LUCENE-3965.patch, LUCENE-3965.patch, LUCENE-3965.patch, 
> LUCENE-3965.patch, LUCENE-3965_module_build.patch, 
> LUCENE-3965_module_build_pname.patch
>
>
> I think users get confused about how svn/source is structured,
> when in fact we are just producing a modular build.
> I think it would be more clear if the lucene stuff was underneath
> modules/, thats where our modular API is.
> we could still package this up as lucene.tar.gz if we want, and even name
> modules/core lucene-core.jar, but i think this would be a lot better
> organized than the current:
> * lucene
> * lucene/contrib
> * modules
> confusion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to