[
https://issues.apache.org/jira/browse/LUCENE-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257945#comment-13257945
]
Chris Male commented on LUCENE-4001:
------------------------------------
I have real reservations about doing this. In LUCENE-3997 I explained that I
feel we should only move classes into core if they are part of core APIs /
concepts. I don't think FunctionValues and ValueSource are in that boat. To
me they seem tightly bound to FunctionQuery and the implementations in the
queries module. Yes the grouping module uses them, but that doesn't
immediately make them core. I also feel that in 99% of cases, people who want
to group by function will be using the impls in the queries module, so why
remove the dependency?
> Grouping module shouldn't depend on queries module
> --------------------------------------------------
>
> Key: LUCENE-4001
> URL: https://issues.apache.org/jira/browse/LUCENE-4001
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Martijn van Groningen
>
> Spin off from LUCENE-3997. Basically move FunctionValues and ValueSource to
> core.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
