[ https://issues.apache.org/jira/browse/LUCENE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258822#comment-13258822 ]
Martijn van Groningen commented on LUCENE-3997: ----------------------------------------------- The reason that joining and grouping are different modules is that these are different functionalities. However these functionalities do overlap a bit with each other. Both joining and grouping can be used for a parent child like search. I'm not sure what would be a good option. Joining does use grouping's TopGroups and GroupDocs... If we are going to have a combined module maybe we should name it relational module or parent child module? > join module should not depend on grouping module > ------------------------------------------------ > > Key: LUCENE-3997 > URL: https://issues.apache.org/jira/browse/LUCENE-3997 > Project: Lucene - Java > Issue Type: Task > Affects Versions: 4.0 > Reporter: Robert Muir > Fix For: 4.0 > > Attachments: LUCENE-3997.patch, LUCENE-3997.patch > > > I think TopGroups/GroupDocs should simply be in core? > Both grouping and join modules use these trivial classes, but join depends on > grouping just for them. > I think its better that we try to minimize these inter-module dependencies. > Of course, another option is to combine grouping and join into one module, but > last time i brought that up nobody could agree on a name. > Anyway I think the change is pretty clean: its similar to having basic stuff > like Analyzer.java in core, > so other things can work with Analyzer without depending on any specific > implementing modules. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org