[ https://issues.apache.org/jira/browse/SOLR-3424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264986#comment-13264986 ]
Uwe Schindler commented on SOLR-3424: ------------------------------------- Thanks! Thaks for taking care, as I have no time to provide a patch at the moment :( bq. but I will since it seems to be a big deal to you (three exclamation points) :-) It's not so important, if it's private to the class! I just don't want public code to expose Collections not intended to be modified in a modifiable way, so i am fine with or without unmodifiable. There are also places in Lucene violating this (or use public arrays, which cannot be protected - like CompositeReader.getSequentialSubReaders()). > PhoneticFilterFactory threadsafety bug > -------------------------------------- > > Key: SOLR-3424 > URL: https://issues.apache.org/jira/browse/SOLR-3424 > Project: Solr > Issue Type: Bug > Components: Schema and Analysis > Affects Versions: 3.6, 4.0 > Reporter: David Smiley > Assignee: David Smiley > Priority: Minor > Fix For: 4.0 > > Attachments: SOLR-3424_PhoneticFilterFactory_threadsafety_bug.patch > > > PhoneticFilterFactory has a static HashMap registry mapping an encoder name > to an implementation. There is a ReentrantLock used when the map is modified > (when the encoder config specifies a class name). However, this map, which > can be accessed by multiple indexing threads, isn't guarded on any of the > reads, which isn't just the common path but also the error messages which > dump the registry into the error message. > I realize the likelihood of a problem is extremely slim, but a bug's a bug. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org