[
https://issues.apache.org/jira/browse/SOLR-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278327#comment-13278327
]
Andrzej Bialecki commented on SOLR-2822:
-----------------------------------------
This looks good. Some comments:
* javadocs should mention somewhere (UpdateProcessorRequestChain) the skipping
of parts of the chain when FROMLEADER is seen.
* tests don't seem to cover any case that uses requests with TOLEADER set.
* re. comment in UpdateRequestProcessorChain, where DUPFactory() is inserted if
missing: I'd say if someone forgot or is unaware of the need for a distrib
processor then it should be inserted as it is done in the patch - right before
the run processor, so that all modifications to documents are completed before
distributing (modifications could affect the shard #).
* minor nits:
** BasicDistributedZkTest.testUpdateProcessorsRunOnlyOnce() has a hanging
:TODO:, not sure what it refers to?
** DistributingUpdateProcessorFactory: typos "not inteded", "skiped".
** DistributedUpdateProcessor: typo "exposted"
** UpdateRequestProcessorChain: mentions
DistributedUpdateProcessorFactoryMarker, "then and".
> don't run update processors twice
> ---------------------------------
>
> Key: SOLR-2822
> URL: https://issues.apache.org/jira/browse/SOLR-2822
> Project: Solr
> Issue Type: Sub-task
> Components: SolrCloud, update
> Reporter: Yonik Seeley
> Fix For: 4.0
>
> Attachments: SOLR-2822.patch
>
>
> An update will first go through processors until it gets to the point where
> it is forwarded to the leader (or forwarded to replicas if already on the
> leader).
> We need a way to skip over the processors that were already run (perhaps by
> using a processor chain dedicated to sub-updates?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
