[ https://issues.apache.org/jira/browse/LUCENE-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283977#comment-13283977 ]
Ippei UKAI edited comment on LUCENE-4072 at 5/26/12 1:25 PM: ------------------------------------------------------------- I've found a problem: In ICUNormalizer2CharFilter#recordOffsetDiff(int,int), the positive diff case should look like following. <pre> addOffCorrectMap(charCount + Math.min(1, outputLength), cumuDiff + diff); </pre> Hopefully, there won't be more. I do grant license to ASF to include the above line in ASF works (as per the Apache License ยง5) was (Author: ippei): I've found a problem: In ICUNormalizer2CharFilter#recordOffsetDiff(int,int), the positive diff case should look like following. <pre> addOffCorrectMap(charCount + Math.min(1, outputLength), cumuDiff + diff); </pre> Maybe there are more... > CharFilter that Unicode-normalizes input > ---------------------------------------- > > Key: LUCENE-4072 > URL: https://issues.apache.org/jira/browse/LUCENE-4072 > Project: Lucene - Java > Issue Type: New Feature > Components: modules/analysis > Reporter: Ippei UKAI > Attachments: DebugCode.txt, LUCENE-4072.patch, > ippeiukai-ICUNormalizer2CharFilter-4752cad.zip > > > I'd like to contribute a CharFilter that Unicode-normalizes input with ICU4J. > The benefit of having this process as CharFilter is that tokenizer can work > on normalised text while offset-correction ensuring fast vector highlighter > and other offset-dependent features do not break. > The implementation is available at following repository: > https://github.com/ippeiukai/ICUNormalizer2CharFilter > Unfortunately this is my unpaid side-project and cannot spend much time to > merge my work to Lucene to make appropriate patch. I'd appreciate it if > anyone could give it a go. I'm happy to relicense it to whatever that meets > your needs. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org