[ https://issues.apache.org/jira/browse/LUCENE-3976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287260#comment-13287260 ]
Luca Cavanna commented on LUCENE-3976: -------------------------------------- Hi Chris, I agree with you. On the other hand with the affix rule mentioned, before LUCENE-4019 we had an AOE, so the additional catch would have been useful just to throw a nicer error message like "Error while parsing the affix file". That one has been solved at its source, for now I don't see any other possible errors but I'm sure there are some, maybe plenty since we support only a subset of the formats and features. It was just a way to introduce a generic error message but I totally agree that the right apporach would be fixing everything at the source. > Improve error messages for unsupported Hunspell formats > ------------------------------------------------------- > > Key: LUCENE-3976 > URL: https://issues.apache.org/jira/browse/LUCENE-3976 > Project: Lucene - Java > Issue Type: Improvement > Components: modules/analysis > Reporter: Chris Male > Attachments: LUCENE-3976.patch, LUCENE-3976.patch > > > Our hunspell implementation is never going to be able to support the huge > variety of formats that are out there, especially since our impl is based on > papers written on the topic rather than being a pure port. > Recently we ran into the following suffix rule: > {noformat}SFX CA 0 /CaCp{noformat} > Due to the missing regex conditional, an AOE was being thrown, which made it > difficult to diagnose the problem. > We should instead try to provide better error messages showing what we were > unable to parse. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org