[ https://issues.apache.org/jira/browse/SOLR-3267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man resolved SOLR-3267. ---------------------------- Resolution: Fixed I think my thought process when putting the "numberOfOddities" check in that test was that we shouldn't fail if a randomly generated string just happened to wind up being a valid function, or all control/blank characters, (or "score", or "_docid_) ... but that if it happened more then a non-trivial number of times, that was odd and should cause a failure so someone would look at the test. Looking at some of hte problematic seeds, i realized that the common situation with oddities was: * randomly generated strings that were all whitespace and/or control characters * randomly generated strings that were valid quote sequences (which means they can be treated as a (literal) function. so i changed it as follows... * removed all the "oddity" checking * added loop in the event that a random string is all whitespace, but made it fail hard if 37 attempts all produce strings that are entirely whitespace (rather then an "infinite" loop) * improved the "munging" of the random strings to ensure they aren't valid functions (or literal quoted strings) * made the test fail hard if any string produced parses as a function or query instead of a field name. Committed revision 1350444. - trunk Committed revision 1350445. - 4x > TestSort failures (reproducible) > -------------------------------- > > Key: SOLR-3267 > URL: https://issues.apache.org/jira/browse/SOLR-3267 > Project: Solr > Issue Type: Bug > Reporter: Dawid Weiss > Assignee: Hoss Man > Fix For: 4.0 > > > {noformat} > Over 0.2% oddities in test: 14/6386 have func/query parsing semenatics gotten > broader? > {noformat} > Huh? Steps to reproduce: > {noformat} > ant test -Dtestcase=TestSort -Dtestmethod=testRandomFieldNameSorts > -Dtests.seed=-3e789c8564f08cbd:515c61b079794ea7:-6347ac0df7ad45c0 > -Dargs="-Dfile.encoding=UTF-8" > [junit] Testcase: > testRandomFieldNameSorts(org.apache.solr.search.TestSort): FAILED > [junit] Over 0.2% oddities in test: 14/6386 have func/query parsing > semenatics gotten broader? > [junit] junit.framework.AssertionFailedError: Over 0.2% oddities in test: > 14/6386 have func/query parsing semenatics gotten broader? > [junit] at org.junit.Assert.fail(Assert.java:93) > [junit] at org.junit.Assert.assertTrue(Assert.java:43) > [junit] at > org.apache.solr.search.TestSort.testRandomFieldNameSorts(TestSort.java:145) > [junit] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > [junit] at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) > [junit] at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) > [junit] at java.lang.reflect.Method.invoke(Method.java:597) > [junit] at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45) > [junit] at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) > [junit] at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42) > [junit] at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20) > [junit] at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28) > [junit] at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:30) > [junit] at > org.apache.lucene.util.SystemPropertiesRestoreRule$1.evaluate(SystemPropertiesRestoreRule.java:63) > [junit] at > org.apache.lucene.util.LuceneTestCase$SubclassSetupTeardownRule$1.evaluate(LuceneTestCase.java:739) > [junit] at > org.apache.lucene.util.LuceneTestCase$InternalSetupTeardownRule$1.evaluate(LuceneTestCase.java:655) > [junit] at > org.apache.lucene.util.SystemPropertiesInvariantRule$1.evaluate(SystemPropertiesInvariantRule.java:69) > [junit] at > org.apache.lucene.util.LuceneTestCase$TestResultInterceptorRule$1.evaluate(LuceneTestCase.java:566) > [junit] at > org.apache.lucene.util.UncaughtExceptionsRule$1.evaluate(UncaughtExceptionsRule.java:75) > [junit] at > org.apache.lucene.util.LuceneTestCase$RememberThreadRule$1.evaluate(LuceneTestCase.java:628) > [junit] at org.junit.rules.RunRules.evaluate(RunRules.java:18) > [junit] at > org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263) > [junit] at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68) > [junit] at > org.apache.lucene.util.LuceneTestCaseRunner.runChild(LuceneTestCaseRunner.java:164) > [junit] at > org.apache.lucene.util.LuceneTestCaseRunner.runChild(LuceneTestCaseRunner.java:57) > [junit] at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231) > [junit] at > org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60) > [junit] at > org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229) > [junit] at > org.junit.runners.ParentRunner.access$000(ParentRunner.java:50) > [junit] at > org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222) > [junit] at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28) > [junit] at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:30) > [junit] at > org.apache.lucene.util.SystemPropertiesRestoreRule$1.evaluate(SystemPropertiesRestoreRule.java:63) > [junit] at > org.apache.lucene.util.UncaughtExceptionsRule$1.evaluate(UncaughtExceptionsRule.java:75) > [junit] at > org.apache.lucene.util.StoreClassNameRule$1.evaluate(StoreClassNameRule.java:38) > [junit] at > org.apache.lucene.util.SystemPropertiesInvariantRule$1.evaluate(SystemPropertiesInvariantRule.java:69) > [junit] at org.junit.rules.RunRules.evaluate(RunRules.java:18) > [junit] at org.junit.runners.ParentRunner.run(ParentRunner.java:300) > [junit] at > junit.framework.JUnit4TestAdapter.run(JUnit4TestAdapter.java:39) > [junit] at > org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:518) > [junit] at > org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:1052) > [junit] at > org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:906) > [junit] > [junit] > [junit] Test org.apache.solr.search.TestSort FAILED > {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org