[ 
https://issues.apache.org/jira/browse/LUCENE-4147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13395854#comment-13395854
 ] 

Michael McCandless commented on LUCENE-4147:
--------------------------------------------

bq. mike, do we really need to acquire the commit lock?

The problem is rollback forcefully clears the pendingCommit and then deletes 
any files it had (alone) referenced, so if a commit is running concurrently the 
fsyncs will fail since the files were deleted.

Also: it doesn't really make sense to allow rollback and commit to proceed 
concurrently?  Why would an app need this?  Seems like we can simplify the code 
by making them exclusive.

bq. regarding the thread safety issue in DocWriter can you paste the trace?

Will do ... need to re-beast.
                
> rollback/preparecommit thread hazard
> ------------------------------------
>
>                 Key: LUCENE-4147
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4147
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>         Attachments: LUCENE-4147.patch, LUCENE-4147.patch
>
>
> found by 
> http://jenkins.sd-datasolutions.de/job/Lucene-Solr-4.x-Windows-Java7-64/70/
> rollback should never throw this exception, as it documents it clears any 
> pendingcommits.
> but it calls closeInternal outside of any sync block, so it looks like there 
> is a race here.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to