[ 
https://issues.apache.org/jira/browse/SOLR-3548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hoss Man updated SOLR-3548:
---------------------------

    Attachment: SOLR-3548.patch

it took a lot longer then i though, but here is a patch that adds QueryUtils 
checking against (at least one of) the Query objects produced by every default 
QParser and ValueSourceParser.  It includes a future proofing "testCoverage" 
that sets a bit informing an AfterClass method to assert that all of the 
default parsers were tested so we don't risk this probably again the next time 
someone adds a new parsers.

Currently 4 methods are failing, indicating the following problems...

* strdist func - identical query strings don't produce equals() queries
* join qparser - clone w/diff boost still has equals hashCode
* bbox qparser - clone w/diff boost still has equals hashCode
* geofilt qparser - clone w/diff boost still has equals hashCode

the hashCode equality isn't the end of the world, but it suggests a really poor 
hashCode impl (that evidently doesn't call super since Query.hashCode already 
handles the boost)


                
> some queries produced by built in QParsers are not .equals() to themselves
> --------------------------------------------------------------------------
>
>                 Key: SOLR-3548
>                 URL: https://issues.apache.org/jira/browse/SOLR-3548
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>            Priority: Blocker
>             Fix For: 4.0, 3.6.1
>
>         Attachments: SOLR-3548.patch, SOLR-3548.patch
>
>
> working on SOLR-3522 i discovered that in some cases Solr is producing 
> queries that aren't equals to themselves, so they can't be cached.
> So far the only observed problem is in func strdist, but i want to make sure 
> we have an exhaustive test of this in case there are others

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to