[
https://issues.apache.org/jira/browse/LUCENE-4171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403018#comment-13403018
]
Adrien Grand commented on LUCENE-4171:
--------------------------------------
Thanks, Toke. I think there are still a few minor fixes to perform:
* the maskLeft variable seems unused, can it be removed?
* the copyright header doens't need to be a javadoc comment (those that start
with /** instead of // or /*), can you fix it?
* since this impl uses the default format, there is no need to override
getFormat
I think it is not necessary to try to keep the same number of blocks as the old
impl (cf. comments in ctor #1 and #3). Could we just use {{size(valueCount,
bitsPerValue)}} to compute the required number of blocks?
> Performance improvements to Packed64
> ------------------------------------
>
> Key: LUCENE-4171
> URL: https://issues.apache.org/jira/browse/LUCENE-4171
> Project: Lucene - Java
> Issue Type: Sub-task
> Components: core/other
> Affects Versions: 4.0, 5.0
> Environment: Tested with 4 different Intel machines
> Reporter: Toke Eskildsen
> Priority: Minor
> Labels: performance
> Attachments: LUCENE-4171.patch, LUCENE-4171.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> Based on the performance measurements of PackedInts.Mutable's in LUCENE-4062,
> a new version of Packed64 has been created that is consistently faster than
> the old Packed64 for both get and set.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
