[ 
https://issues.apache.org/jira/browse/LUCENE-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403805#comment-13403805
 ] 

Dawid Weiss commented on LUCENE-3832:
-------------------------------------

It'd be possible to avoid the sort and still make 
makeUnionOfStrings(Collection<String>) possible if we also exposed Utf16AsUtf8 
comparator... Then the automaton builder could accept either byte[] or char[] 
and just do its job without any additional overhead of copying. 

Ok, I'll remove that method if you don't like it. If there's a need we can 
revert it using the trick above.
                
> Port BasicAutomata.stringUnion from Brics to Lucene
> ---------------------------------------------------
>
>                 Key: LUCENE-3832
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3832
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: core/FSTs
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Trivial
>             Fix For: 4.0, 5.0
>
>         Attachments: LUCENE-3832.patch, LUCENE-3832.patch
>
>
> Brics has my code to build Automaton from a set of sorted strings in one step 
> (Daciuk/Mihov's algorithm again). This should be easily portable to Lucene 
> and is quite useful.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to