[
https://issues.apache.org/jira/browse/LUCENE-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404995#comment-13404995
]
Uwe Schindler commented on LUCENE-4183:
---------------------------------------
btw, the block of code in this issue is *the* classical example for above
pattern! Should I rewrite it? The code is also much shorter than the current if
then else stuff in finally.
> Simplify CompoundFileDirectory opening in 4.x
> ---------------------------------------------
>
> Key: LUCENE-4183
> URL: https://issues.apache.org/jira/browse/LUCENE-4183
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 4.0
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 4.0
>
> Attachments: LUCENE-4183.patch
>
>
> The compiler bug in JDK 8EA let me look at the code again. I opened bug
> report with simple test case at Oracle, but the code on our side is still too
> complicated to understand.
> The attached path for 4.x removes the nested try-finaly block and simpliefies
> success=true handling (which was in fact broken). It uses a more
> try-with-resources like approach with only one finally block.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
