[
https://issues.apache.org/jira/browse/LUCENE-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407221#comment-13407221
]
David Smiley commented on LUCENE-4188:
--------------------------------------
RE createStoredField():
bq. I don't really like this. It is barely an improvement on the current code.
The whole point of this issue is that the storing of Shapes shouldn't be
related to Strategys. I think we should be explicit and require the consumer
code (Solr or something else) decides how it wants to store Shapes. If you want
a convenience method then it should be static, illustrating it is a utility
that the Strategys cannot override. Ideally I would like it somewhere else
entirely.
The client doesn't have to use this method, but in all tests + the Solr
adapters I don't think there's a reason not to. I found it to be useful, and
to provide a place to document how it is recommended to store the shape (notice
I even included the one-liner source in the javadocs). An advantage of it
being an instance method on the Strategy is that it has convenient access to
both the field name & SpatialContext. I could make this method final, and I
could add more documentation that makes it clear that the user is free to store
the shape in any way they wish since the spatial module doesn't care.
> Storing Shapes shouldn't be Strategy dependent
> ----------------------------------------------
>
> Key: LUCENE-4188
> URL: https://issues.apache.org/jira/browse/LUCENE-4188
> Project: Lucene - Java
> Issue Type: Bug
> Components: modules/spatial
> Reporter: Chris Male
> Assignee: David Smiley
> Attachments: LUCENE-4188_remove_field_storage_from_createField.patch
>
>
> The logic for storing Shape representations seems to be different for each
> Strategy. The PrefixTreeStrategy impls store the Shape in WKT, which is nice
> if you're using WKT but not much help if you're not. BBoxStrategy doesn't
> actually store the Shape itself, but a representation of the bounding box.
> TwoDoubles seems to follow the PrefixTreeStrategy approach, which is
> surprising since it only indexes Points and they could be stored without
> using WKT.
> I think we need to consider what storing a Shape means. If we want to store
> the Shape itself, then that logic should be standardised and done outside of
> the Strategys since it is not really related to them. If we want to store
> the terms being used by the Strategys to make Shapes queryable, then we need
> to change the logic in the Strategys to actually do this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
