[ https://issues.apache.org/jira/browse/SOLR-3594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407416#comment-13407416 ]
Hoss Man commented on SOLR-3594: -------------------------------- bq. The real question here is unrelated to tests: should the SolrCore constructor should wait for a searcher to be registered before returning? i don't think so. Just because a searcher isn't available yet, doesn't mean the SolrCore is unusable - we shouldn't block other uses of the SolrCore just because a searcher isn't available yet. the first thread that attempts to use getSearcher() is what should block on the listeners (depending on the setting of useColdSearcher) The test failure suggests to me that something is wonky with how were are tracking the searcher opens and doing cleanup -- either in SolrCore.close() or in the test framework itself. > SolrCore() doesn't wait SolrCore.getSearcher() to register _searcher > -------------------------------------------------------------------- > > Key: SOLR-3594 > URL: https://issues.apache.org/jira/browse/SOLR-3594 > Project: Solr > Issue Type: Bug > Components: clients - java > Affects Versions: 3.4 > Reporter: Egor Pahomov > Priority: Minor > Labels: test > Attachments: 3594.patch, testSearchersManagement.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > SolrCore() executes SolrCore.getSearcher(...) and returns without checking if > getSearcher(...) already registered _searcher. As result: if we have > SolrEventListener with slow newSearcher(), we can end test before _searcher > registered and get then searcher closes and searcher opens doesn't match. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org