[ 
https://issues.apache.org/jira/browse/LUCENE-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414618#comment-13414618
 ] 

Michael McCandless commented on LUCENE-4221:
--------------------------------------------

+1 to disabling the checks (the patch): CheckIndex should never fail just 
because analyzer was buggy.

+1 also for that plan to remove bad offsets on merge.
                
> CheckIndex is overeager for term vector offsets bounds checks
> -------------------------------------------------------------
>
>                 Key: LUCENE-4221
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4221
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0-ALPHA
>            Reporter: Robert Muir
>             Fix For: 4.0, 5.0
>
>         Attachments: LUCENE-4221.patch
>
>
> In some situations (like running shingles twice), you end out with a case 
> where startOffset > endOffset.
> We prevent this in IndexWriter for postings offsets, but we never do any 
> validation here for term vectors (at some point, maybe we should make a plan 
> to address this?)
> Anyway, currently CheckIndex will wrongly fail in this situation, which some 
> of our own analyzers even do (e.g. LUCENE-3920)...
> This is an overly-eager validation in checkindex (for vectors, we cannot 
> safely do these assertions as it was/is never enforced by IndexWriter, only 
> for postings offsets).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to