[ 
https://issues.apache.org/jira/browse/LUCENE-4220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Uwe Schindler updated LUCENE-4220:
----------------------------------

    Attachment: LUCENE-4220.patch

The original patch had a bug (which was caused by my misunderstanding and 
missing test data).

Other changes:
- the new Parser now correctly implements TrecParser interface and also cleans 
up the whole HTMLParser interface.
- removed useless InterruptedException from method signatures (was only there 
because of the crazy old parser)
- Fixed NPE in parsing date from <meta.../> elements

It would be good if someone (e.g. Doron Cohen, who wrote the original parser or 
anybody else who has a license) could temporarily provide the Gov2 TREC 
collection to me, so that I can check that all is working as expected. The test 
data is horrible small.

Nevertheless, I will commit the current state soon to trunk and 4.x.
                
> Replace benchmarks crazy HTML parser by a nekohtml 10-liner
> -----------------------------------------------------------
>
>                 Key: LUCENE-4220
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4220
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: modules/benchmark
>    Affects Versions: 4.0-ALPHA
>            Reporter: Uwe Schindler
>             Fix For: 4.0, 5.0
>
>         Attachments: LUCENE-4220.patch, LUCENE-4220.patch, LUCENE-4220.patch
>
>
> Benchmark contains a javacc-based HTML parser which of course violates all 
> specs, is huge and error prone.
> I can replace it by a NEKOHTML based one (approx 10 - 20 lines of code). 
> NEKOHTML is an extension for XERCES (that we already use to read wikipedia), 
> that produces SAX-events or DOM tree out of a HTML file usingg standard XML 
> APIS. We could also use TIKA, but I refuse to download the Internet to get 
> TIKA running for just parsing a HTML file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to