[
https://issues.apache.org/jira/browse/LUCENE-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415101#comment-13415101
]
Uwe Schindler commented on LUCENE-2191:
---------------------------------------
+1 Commit thats, in 4.0 we have no backwards issues, so this is easy.
Tokenizer.setReader(Reader) is the only reasonable method name. reset() is
something you have to call in all cases!
> rename Tokenizer.reset(Reader) to Tokenizer.setReader(Reader)
> -------------------------------------------------------------
>
> Key: LUCENE-2191
> URL: https://issues.apache.org/jira/browse/LUCENE-2191
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/analysis
> Reporter: Robert Muir
> Priority: Minor
> Fix For: 4.0, 5.0
>
> Attachments: LUCENE-2191.patch, LUCENE-2191.patch
>
>
> in TokenStream there is a reset() method, but the method in Tokenizer used to
> set a new Reader is called reset(Reader).
> in my opinion this name overloading creates a lot of confusion, and we see
> things like reset(Reader) calling reset() even in StandardTokenizer...
> So I think this would be some work to fulfill all the backwards
> compatibility, but worth it because when you look at the existing
> reset(Reader) and reset() code in various tokenizers, or the javadocs for
> Tokenizer, its pretty confusing and inconsistent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
