[
https://issues.apache.org/jira/browse/LUCENE-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415206#comment-13415206
]
Chris Male commented on LUCENE-4167:
------------------------------------
bq. Okay then. So a SpatialUtil class with a private no-arg constructor with
static methods?
Yeah something like that.
bq. By the way, I was not suggesting makeCustomValueSource() be on the Strategy
API, it would be specific to BBoxStrategy.
Ah okay. Perhaps we can call it makeOverlapValueSource() then? if that's what
the value is
bq. So... are we then talking about a makeInvertedDistanceValueSource() method?
Hmm, this is somewhat less satisfying. Perhaps instead a boolean argument to
invert it?
No I don't think we need to call it that or make the differentiation. Our
makeDistanceValueSource() should return the inverted distance since it's
arguably more useful. If people want the original distance (maybe for display
sake) then they can un-invert it themselves.
> Remove the use of SpatialOperation
> ----------------------------------
>
> Key: LUCENE-4167
> URL: https://issues.apache.org/jira/browse/LUCENE-4167
> Project: Lucene - Java
> Issue Type: Bug
> Components: modules/spatial
> Reporter: Chris Male
> Attachments: LUCENE-4167.patch,
> LUCENE-4167_migrate_com_spatial4j_core_query_to_Lucene_spatial.patch,
> LUCENE-4167_migrate_com_spatial4j_core_query_to_Lucene_spatial.patch
>
>
> Looking at the code in TwoDoublesStrategy I noticed
> SpatialOperations.BBoxWithin vs isWithin which confused me. Looking over the
> other Strategys I see that really only isWithin and Intersects is supported.
> Only TwoDoublesStrategy supports IsDisjointTo. The remainder of
> SpatialOperations are not supported.
> I don't think we should use SpatialOperation as this stage since it is not
> clear what Operations are supported by what Strategys, many Operations are
> not supported, and the code for handling the Operations is usually the same.
> We can spin off the code for TwoDoublesStrategy's IsDisjointTo support into a
> different Strategy.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
