[
https://issues.apache.org/jira/browse/SOLR-3634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hoss Man updated SOLR-3634:
---------------------------
Attachment: SOLR-3634.patch
quick patch with all the major functionality and some tests.
lots of nocommits in here, basicly all falling into three categories:
* refactoring - the changes to CoreContainer are all complete and relatively
trivial, but involved renaming create/reload to doCreate/doReload which are
wrapped in new stub methods that call them in try blocks where the "finally"
does all the real work. This was just for convinience to keep the patch easy
to read w/o a lot of re-indenting, and these methods should be refactored away
before committing.
* more tests - the key stuff is already covered in the patch, and i did manual
testing with CoreAdminHandler, but i definitely want more tests before
committing.
* "Directory not closed" - something about this test is causing MockDirWrapper
to complain it's never closed - buti don't think this is a bug in the new code
or the test. I suspect we have an existing bug where SolrCore initialization
failures *after* the Directory has already been opened aren't closing the
Directory -- so we should get to hte bottom of that (probably in a new issue if
i'm correct)
> make CoreAdminHandler STATUS action report back info about core
> initialization failures
> ----------------------------------------------------------------------------------------
>
> Key: SOLR-3634
> URL: https://issues.apache.org/jira/browse/SOLR-3634
> Project: Solr
> Issue Type: Sub-task
> Reporter: Hoss Man
> Assignee: Hoss Man
> Fix For: 4.0
>
> Attachments: SOLR-3634.patch
>
>
> see parent issue for context.
> * CoreContainer should keep a record of failures related to core
> initialization, keyed off of the core name
> * failures should be recorded for both solr.xml initialzation, as well as
> explicit CREATE/RELOAD requests that fail
> * record of failures should be tracked indefinitely until some valid core
> begins using that name
> ** ie: actions which register a SolrCore with a name (RELOAD, CREATE, SWAP,
> ALIAS) should "reset" any existing failures associated with that name
> * failures should be available to clients via CoreAdminHandler STATUS actions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
