[ 
https://issues.apache.org/jira/browse/SOLR-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13419662#comment-13419662
 ] 

Hoss Man commented on SOLR-3623:
--------------------------------

rmuir: sorry, but i'm totally lost -- too many unspoken assumptions in my 
comment, and some vagueness in your comments has me turned around...

bq. only the morfologik jars are misplaced. so there is no 
lucene-analyzers-smartcn etc in solr core.

* can you be specific as to what you mean by "the morfologik jars" ? because 
evidently i don't have a clue what that means and i missunderstood what you 
were including in that list originally (i thought you ment all of the 
anlysis-extra libs that weren't ICU).
* can you clarify what you think the "misplaced" location(s) are?
* are you saying it is good or bad that lucene-analyzers-smartcn is not 
currently in solr core? (ie: in your opinion, should SmartChinese\*Factory move 
into solr/core ?)

bq. the morfologik jars may be in the wrong place, but they are not configured 
in classpaths for solr core (e.g. solr.base.classpath)

* again: what exactly do you mean by "wrong place" ?
* am i correct in understanding that you feel they _should_ be in the war file, 
but that it is a mistake they are not included in solr.base.classpath at 
compile time?

bq. a quick glance at that reveals other things in that classpath that shouldnt 
be in there like analyzers-uima.jar (which, should instead be configured in the 
uima contrib's classpath only)

Skimming the build files ... if i understand correctly how things work in the 
ivy world ... the crux of the problem appears to be that "lucene-jars-to-solr" 
uses a fileset which is not equivalent to the "solr.base.classpath" used for 
compilation & tests ... is that it?

(A {{<path />}} can contain "{{<fileset/>}}"s (and fileset references), and 
"{{<path/>}}"s can be used inside {{<copy/>}} -- so it should be easy to 
eliminate some redundancy here and have most of this in a single "path" 
refrenced by ID in both "solr.base.classpath" and the "lucene-jars-to-solr" 
{{<copy/>}})

                
> analysis-extras lucene libraries are redundenly packaged (in war and in 
> lucene-libs)
> ------------------------------------------------------------------------------------
>
>                 Key: SOLR-3623
>                 URL: https://issues.apache.org/jira/browse/SOLR-3623
>             Project: Solr
>          Issue Type: Bug
>          Components: Build
>            Reporter: Lance Norskog
>            Assignee: Hoss Man
>            Priority: Minor
>             Fix For: 4.0, 5.0
>
>
> Various dependencies for contrib/analysis-extras are packaged 
> contrib/analysis-extras/lucene-libs (along with instructions in 
> contrib/analysis-extras/README.txt that users need to include them 
> explicitly) even though these jars are already hardcoded into the solr war 
> file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to