[
https://issues.apache.org/jira/browse/LUCENE-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420627#comment-13420627
]
Michael McCandless commented on LUCENE-4246:
--------------------------------------------
{quote}
Perhaps, if you want to simplify, close() should just commit and NEVER wait for
merges. If someone wants that, he can call commit() + waitForMerges().
{quote}
I think you mean waitForMerges(), then commit()? Else the merges aren't
committed...
I think this idea (close simply closes) makes sense! But:
Would close() throw an exception if there were pending (uncommitted,
un-rolled-back) changes? Ie to avoid the obvious trap of users on upgrading
assuming close still implicitly calls commit else they silently lose their
changes.
Also if merges are still running I think close() should throw an exception,
else CMS will be silently starved (never able to complete a large merge) for
apps that open IW, add/update some docs, commit, close. We'd need to open up a
"stopAllMerges" call.
> Fix IndexWriter.close() to not commit or wait for pending merges
> ----------------------------------------------------------------
>
> Key: LUCENE-4246
> URL: https://issues.apache.org/jira/browse/LUCENE-4246
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Assignee: Robert Muir
> Fix For: 4.0
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
