[ https://issues.apache.org/jira/browse/LUCENE-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421316#comment-13421316 ]
Chris Male commented on LUCENE-4044: ------------------------------------ I was testing my Solr integration code and ran into needing to move MockTokenizerFactory (which is in solr/test-framework}. Moving it to lucene/test-framework alongside MockTokenizer doesn't seem to be an option since test-framework doesn't depend on the analysis module. Moving it into the analysis module main src doesn't seem to be an option either since test-framework is a test scoped dependency. It would be possible to put it into the analysis module test code but then it's not distributed like it is in test-framework. Any ideas? > Add NamedSPILoader support to TokenizerFactory, TokenFilterFactory and > CharFilterFactory > ---------------------------------------------------------------------------------------- > > Key: LUCENE-4044 > URL: https://issues.apache.org/jira/browse/LUCENE-4044 > Project: Lucene - Core > Issue Type: Sub-task > Components: modules/analysis > Reporter: Chris Male > Fix For: 4.0 > > Attachments: LUCENE-4044.patch > > > In LUCENE-2510 I want to move all the analysis factories out of Solr and into > the directories with what they create. This is going to hamper Solr's > existing strategy for supporting {{solr.*}} package names, where it replaces > {{solr}} with various pre-defined package names. One way to tackle this is > to use NamedSPILoader so we simply look up {{StandardTokenizerFactory}} for > example, and find it wherever it is, as long as it is defined as a service. > This is similar to how we support Codecs currently. > As noted by Robert in LUCENE-2510, this would also have the benefit of > meaning configurations could be less verbose, would aid in fully decoupling > the analysis module from Solr, and make the analysis factories easier to > interact with. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org