bq. we do not want 'failonerror="false"' when building the example
Yes. "if directory is there, remove it and fail on error" is the right
ant pattern.
This bug is in no way fixed on trunk. Do a fresh trunk checkout from git and:
ant clean
cd solr
ant example
This will fail at line 53 of solr/build.xml:
{code}
/Users/lancenorskog/Documents/open/solr/lucene-solr/solr/build.xml:53:
Directory does not exist:
/Users/lancenorskog/Documents/open/solr/lucene-solr/solr/example/solr-webapp
{code}
git ignores the .gitignore file and does not check out solr-webapps. A
.gitignore file inside solr-webapps does not make sense, if ant
removes solr-webapps. Maybe the .gitignore should be one directory up,
in solr/example, and it ignores solr-webapps?
solr/build.xml, line 53, needs "if directory is there, remove it and
fail on error".
On Tue, Jul 24, 2012 at 6:17 PM, Hoss Man (JIRA) <[email protected]> wrote:
>
> [
> https://issues.apache.org/jira/browse/SOLR-3643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
>
> Hoss Man resolved SOLR-3643.
> ----------------------------
>
> Resolution: Fixed
>
> we do not want 'failonerror="false"' when building the example ... if the
> delete failsit could mean old files are left in the solr-webapp dir which
> would make the webapp "corrupt" -- a mix of old jars and new jars.
>
> presumably the cause of the problem reported here is using a git2svn bridge
> (as mentioned in a comment in SOLR-3609) and the fact that we didn't have a
> solr-webapp/.gitignore to ensure that git would see the empty dir.
>
> this was fixed as part of SOLR-3609
>
>> Bug in 'ant example' build - solr/example/solr-webapp might not exist
>> ---------------------------------------------------------------------
>>
>> Key: SOLR-3643
>> URL: https://issues.apache.org/jira/browse/SOLR-3643
>> Project: Solr
>> Issue Type: Bug
>> Components: Build
>> Affects Versions: 4.0, 5.0
>> Reporter: Lance Norskog
>>
>> In 4.x or trunk, 'ant example' assumes that there is an old
>> example/solr-webapp and attempts to remove it. The rule to remove it should
>> ignore errors.
>> {code}
>> diff --git solr/build.xml solr/build.xml
>> index ec1fcee..142d2b6 100644
>> --- solr/build.xml
>> +++ solr/build.xml
>> @@ -50,7 +50,7 @@
>> <attribute name="Main-Class"
>> value="org.apache.solr.util.SimplePostTool"/>
>> </manifest>
>> </jar>
>> - <delete includeemptydirs="true">
>> + <delete includeemptydirs="true" failonerror="false">
>> <fileset dir="${example}/solr-webapp" includes="**/*"/>
>> </delete>
>> <echo>See ${example}/README.txt for how to run the Solr example
>> configuration.</echo>
>> {code}
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators:
> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
--
Lance Norskog
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
