[
https://issues.apache.org/jira/browse/LUCENE-4256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422876#comment-13422876
]
Chris Male commented on LUCENE-4256:
------------------------------------
{quote}
I think of it as just a way of taking String/String args mostly though.
The other stuff is actually already supported by Analyzer easily: its just
that you have to write code to make use of it since its strongly typed.
{quote}
Yeah good point. I guess I was over thinking the purpose of the Factorys.
bq. Maybe we could start with this? It should be a relatively rote change.
Do you think I should put the Version back as a String in the args map? or
leave it typed.
> Improve Analysis Factory configuration workflow
> -----------------------------------------------
>
> Key: LUCENE-4256
> URL: https://issues.apache.org/jira/browse/LUCENE-4256
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/analysis
> Reporter: Chris Male
>
> With the Factorys now available for more general use, I'd like to look at
> ways to improve the configuration workflow. Currently it's a little disjoint
> and confusing, especially around using {{inform(ResourceLoader)}}.
> What I think we should do is:
> - Remove the need for {{ResourceLoaderAware}} and pass in the ResourceLoader
> in {{init}}, so it'd become {{init(Map<String, String> args, ResourceLoader
> loader)}}
> - Consider moving away from the generic args Map and using setters. This
> gives us better typing and could mitigate bugs due to using the wrong
> configure key. However it does force the consumer to invoke each setter.
> - If we're going to stick with using the args Map, then move the Version
> parameter into {{init}} as well, rather than being a setter as I currently
> made it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
