[
https://issues.apache.org/jira/browse/LUCENE-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425827#comment-13425827
]
Dawid Weiss commented on LUCENE-3985:
-------------------------------------
I'd say no threads should be left after a suite completes, really, but I
understand the pattern of having a static executor to which tasks are
dispatched. Shutting it down will be difficult because it's effectively a
one-time initialization singleton. I consider this "safe" because these threads
in general just wait idly for jobs. I cannot rule out that they are still
processing something but checking this adds more overhead than necessary. We
could shorten the expiration time on these executors and increase lingering
beyond this expiration time so theoretically it's possible to wait for a clean
state but I think it'll increase tests time to an unacceptable level (didn't
check though).
That one particular test suite leaks threads that have stack traces reaching
into solr though -- if you care to take a look at see what they are and if some
kind of shutdown is missing, I'd appreciate.
> Refactor support for thread leaks
> ---------------------------------
>
> Key: LUCENE-3985
> URL: https://issues.apache.org/jira/browse/LUCENE-3985
> Project: Lucene - Core
> Issue Type: Improvement
> Components: general/test
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3985.patch
>
>
> This will be duplicated in the runner and in LuceneTestCase; try to
> consolidate.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
