Ouch. Can't our new SecurityManager block any code from calling System.exit?
(doesn't help users, but would have at least help us discover this in tests right?) : Date: Mon, 3 Sep 2012 13:03:13 +0200 : From: Dawid Weiss <[email protected]> : Reply-To: [email protected] : To: [email protected] : Subject: Re: svn commit: r1379362 - in : /lucene/dev/branches/branch_4x/solr/core/src/test/org/apache/solr/cloud: : BasicDistributedZk2Test.java BasicDistributedZkTest.java : : Oh man... now I know why the hell the JVM terminates with error 11... : : SyncThread's interrupt causes this: : : } catch (Throwable t) { : LOG.fatal("Severe unrecoverable error, exiting", t); : System.exit(11); : } : : D. : : On Fri, Aug 31, 2012 at 5:21 PM, Dawid Weiss : <[email protected]> wrote: : > Oh yeah -- you mentioned it to me once, but I forgot about it. Thanks, : > I'll see if this was the cause. : > : > Dawid : > : > On Fri, Aug 31, 2012 at 3:12 PM, Robert Muir <[email protected]> wrote: : >> FYI: I'm not sure if this is related, but there is a thread from : >> zookeeper "SyncThread" that you should never interrupt. : >> : >> Back in the day interrupting this thread in freebsd jenkins (but also : >> locally on windows or linux) would cause JVM crashes. : >> : >> so the old huge hairy LuceneTestCase had this code: : >> : >> if (!t.getName().startsWith("SyncThread")) // avoid zookeeper jre crash : >> t.interrupt() : >> : >> Not sure if its still applicable. : >> : >> On Fri, Aug 31, 2012 at 4:39 AM, <[email protected]> wrote: : >>> Author: dweiss : >>> Date: Fri Aug 31 08:39:29 2012 : >>> New Revision: 1379362 : >>> : >>> URL: http://svn.apache.org/viewvc?rev=1379362&view=rev : >>> Log: : >>> Don't interrupt threads in this test, just report thread leak errors. Should help get past the broken (?) freebsd jvm. : >>> : >>> Modified: : >>> lucene/dev/branches/branch_4x/solr/core/src/test/org/apache/solr/cloud/BasicDistributedZk2Test.java : >>> lucene/dev/branches/branch_4x/solr/core/src/test/org/apache/solr/cloud/BasicDistributedZkTest.java : >>> : >>> Modified: lucene/dev/branches/branch_4x/solr/core/src/test/org/apache/solr/cloud/BasicDistributedZk2Test.java : >>> URL: http://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/solr/core/src/test/org/apache/solr/cloud/BasicDistributedZk2Test.java?rev=1379362&r1=1379361&r2=1379362&view=diff : >>> ============================================================================== : >>> --- lucene/dev/branches/branch_4x/solr/core/src/test/org/apache/solr/cloud/BasicDistributedZk2Test.java (original) : >>> +++ lucene/dev/branches/branch_4x/solr/core/src/test/org/apache/solr/cloud/BasicDistributedZk2Test.java Fri Aug 31 08:39:29 2012 : >>> @@ -34,16 +34,16 @@ import org.apache.solr.common.params.Com : >>> import org.apache.solr.common.params.ModifiableSolrParams; : >>> import org.apache.solr.servlet.SolrDispatchFilter; : >>> : >>> +import com.carrotsearch.randomizedtesting.annotations.ThreadLeakAction; : >>> +import com.carrotsearch.randomizedtesting.annotations.ThreadLeakAction.Action; : >>> + : >>> /** : >>> * This test simply does a bunch of basic things in solrcloud mode and asserts things : >>> * work as expected. : >>> */ : >>> +@ThreadLeakAction({Action.WARN}) : >>> public class BasicDistributedZk2Test extends AbstractFullDistribZkTestBase { : >>> - : >>> - public BasicDistributedZk2Test() { : >>> - super(); : >>> - } : >>> - : >>> + : >>> /* : >>> * (non-Javadoc) : >>> * : >>> : >>> Modified: lucene/dev/branches/branch_4x/solr/core/src/test/org/apache/solr/cloud/BasicDistributedZkTest.java : >>> URL: http://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/solr/core/src/test/org/apache/solr/cloud/BasicDistributedZkTest.java?rev=1379362&r1=1379361&r2=1379362&view=diff : >>> ============================================================================== : >>> --- lucene/dev/branches/branch_4x/solr/core/src/test/org/apache/solr/cloud/BasicDistributedZkTest.java (original) : >>> +++ lucene/dev/branches/branch_4x/solr/core/src/test/org/apache/solr/cloud/BasicDistributedZkTest.java Fri Aug 31 08:39:29 2012 : >>> @@ -70,11 +70,15 @@ import org.apache.solr.common.util.Named : >>> import org.apache.solr.update.SolrCmdDistributor.Request; : >>> import org.apache.solr.util.DefaultSolrThreadFactory; : >>> : >>> +import com.carrotsearch.randomizedtesting.annotations.ThreadLeakAction; : >>> +import com.carrotsearch.randomizedtesting.annotations.ThreadLeakAction.Action; : >>> + : >>> /** : >>> * This test simply does a bunch of basic things in solrcloud mode and asserts things : >>> * work as expected. : >>> */ : >>> @Slow : >>> +@ThreadLeakAction({Action.WARN}) : >>> public class BasicDistributedZkTest extends AbstractDistribZkTestBase { : >>> : >>> private static final String DEFAULT_COLLECTION = "collection1"; : >>> : >>> : >> : >> : >> : >> -- : >> lucidworks.com : >> : >> --------------------------------------------------------------------- : >> To unsubscribe, e-mail: [email protected] : >> For additional commands, e-mail: [email protected] : >> : : --------------------------------------------------------------------- : To unsubscribe, e-mail: [email protected] : For additional commands, e-mail: [email protected] : : -Hoss --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
