Erick: There is an issue about this: https://issues.apache.org/jira/browse/LUCENE-4362
----- Uwe Schindler H.-H.-Meier-Allee 63, D-28213 Bremen http://www.thetaphi.de eMail: [email protected] > -----Original Message----- > From: Erick Erickson [mailto:[email protected]] > Sent: Wednesday, September 05, 2012 3:03 PM > To: [email protected] > Subject: Re: [jira] [Commented] (LUCENE-4362) ban tab-indented source > > OK, through the miracles of modern IDEs I can make all the changes (for tabs > only) in just a few minutes, running tests now... > > NOTE: this is just the java files, and a really stupid substitution of two > spaces for > each and every tab. No, I didn't just reformat the whole source tree, though > it > was tempting I'll admit<G>... > > BUT. The freaking patch is 900K for 4x, and it touches 190 java files. I'll be > happy to check all this in, but there's a lot of code out in branches, Git, > what > have you, and I want to give it a couple of days for people to object before > possibly introducing a reconciliation nightmare. > > If nobody objects by the weekend, I'll just commit (I'll create a JIRA) both > for 4x > and trunk. > > So a patch is indicated after all I think? > > Let me know.... > > On Wed, Sep 5, 2012 at 8:39 AM, Erick Erickson <[email protected]> > wrote: > > I'm claiming that fixing tabs isn't worth patch files, although maybe > > a JIRA to track progress, agree? > > > > On Wed, Sep 5, 2012 at 8:37 AM, Erick Erickson <[email protected]> > wrote: > >> Interestingly, this check missed the FrenchStemFilter.java (and I > >> don't know what others) that found tabs by doing a quick search of > >> the Lucene source tree. > >> Does the ant task > >> skip deprecated classes? > >> > >> I like the check, I'll see about doing something about the tabs > >> anyway, that's gruntwork after all... > >> > >> > >> On Wed, Sep 5, 2012 at 6:39 AM, Uwe Schindler (JIRA) <[email protected]> > wrote: > >>> > >>> [ > >>> https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian > >>> .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId > >>> =13448621#comment-13448621 ] > >>> > >>> Uwe Schindler commented on LUCENE-4362: > >>> --------------------------------------- > >>> > >>> Yeah, and with the ANT check, so it is enforced! > >>> If somebody wants to use a tab, e.g. in a string, he can always do > >>> \t > >>> > >>>> ban tab-indented source > >>>> ----------------------- > >>>> > >>>> Key: LUCENE-4362 > >>>> URL: https://issues.apache.org/jira/browse/LUCENE-4362 > >>>> Project: Lucene - Core > >>>> Issue Type: Task > >>>> Reporter: Robert Muir > >>>> Attachments: LUCENE-4362_core.patch > >>>> > >>>> > >>>> This makes code really difficult to read and work with. > >>>> Its easy enough to prevent. > >>>> {noformat} > >>>> Index: build.xml > >>>> > ================================================================ > === > >>>> --- build.xml (revision 1380979) > >>>> +++ build.xml (working copy) > >>>> @@ -77,11 +77,12 @@ > >>>> <or> > >>>> <containsregexp expression="@author\b" casesensitive="yes"/> > >>>> <containsregexp expression="\bno(n|)commit\b" > >>>> casesensitive="no"/> > >>>> + <containsregexp expression="\t" casesensitive="no"/> > >>>> </or> > >>>> </fileset> > >>>> <map from="${validate.currDir}${file.separator}" to="* "/> > >>>> </pathconvert> > >>>> - <fail if="validate.patternsFound">The following files contain > >>>> @author > tags or nocommits:${line.separator}${validate.patternsFound}</fail> > >>>> + <fail if="validate.patternsFound">The following files contain > >>>> + @author tags, tabs or > >>>> + nocommits:${line.separator}${validate.patternsFound}</fail> > >>>> </target> > >>>> {noformat} > >>> > >>> -- > >>> This message is automatically generated by JIRA. > >>> If you think it was sent incorrectly, please contact your JIRA > >>> administrators For more information on JIRA, see: > >>> http://www.atlassian.com/software/jira > >>> > >>> -------------------------------------------------------------------- > >>> - To unsubscribe, e-mail: [email protected] For > >>> additional commands, e-mail: [email protected] > >>> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] For additional > commands, e-mail: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
