[
https://issues.apache.org/jira/browse/SOLR-3825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453287#comment-13453287
]
Grant Ingersoll commented on SOLR-3825:
---------------------------------------
A few comments on the patch:
# SolrMBeanTest fails with this patch due to the description and source being
null
# I don't think we want/need member variables for ids and idScores, as it won't
be thread safe. I'd just loop the DocIterator once, building a StringBuilder
and then calling addToLog on that StringBuilder. This will also avoid the need
for clone()
# For the scores, let's just do an output of id:score, id:score, ... Using a
Map won't be reliable, as we will want to maintain order in the log.
# For the log key, let's just call it the same thing which should simplify
parsing, regardless of whether there are scores present or not, so the format
would be: responseLog: id1[:score1],id2[:score2],... where [ ] is used to
indicate it is optional.
# We should follow the normal SearchComponent pattern of being able to turn
on/off the component via a request parameter. {code}if
(!params.getBool(COMPONENT_NAME, false)) {
return;
}{code} This component should be OFF by default.
# In the ResponseLogComponentTest, do we need the createCore() stuff? See some
of the other tests and how they use initCore.
> Log document IDs when they are retrieved
> ----------------------------------------
>
> Key: SOLR-3825
> URL: https://issues.apache.org/jira/browse/SOLR-3825
> Project: Solr
> Issue Type: Improvement
> Components: SearchComponents - other
> Reporter: Scott Stults
> Assignee: Grant Ingersoll
> Priority: Trivial
> Attachments: SOLR-3825.patch
>
>
> During relevancy tuning it's important to know exactly which documents the
> client has seen. Right now the only way to get that list is to splice into
> the HTTP traffic. Preferably the IDs could be logged along with the query.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
