[
https://issues.apache.org/jira/browse/LUCENE-4173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453312#comment-13453312
]
David Smiley edited comment on LUCENE-4173 at 9/12/12 8:38 AM:
---------------------------------------------------------------
This patch removes ignoreIncompatibleGeometry and modified the strategies to
fail when given a shape that isn't the precise shape used -- no coalescing.
BBox & TwoDoubles were both doing coalescing (e.g. shape.getBoundingBox()).
PrefixTree can handle anything so no change there.
I'll commit this pending your +1 [~cmale].
An enum for FAIL, COALESCE, & IGNORE can be done in another issue if desired.
was (Author: dsmiley):
This patch removes ignoreIncompatibleGeometry and modified the strategies
to fail when given a shape that isn't the precise shape used -- no coalescing.
BBox & TwoDoubles were both doing coalescing (e.g. shape.getBoundingBox()).
PrefixTree can handle anything so change there.
I'll commit this pending your +1 Chris.
An enum for FAIL, COALESCE, or IGNORE can be done in another issue if desired.
> Remove IgnoreIncompatibleGeometry for SpatialStrategys
> ------------------------------------------------------
>
> Key: LUCENE-4173
> URL: https://issues.apache.org/jira/browse/LUCENE-4173
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/spatial
> Reporter: Chris Male
> Assignee: David Smiley
> Attachments: LUCENE-4173.patch,
> LUCENE-4173_remove_ignoreIncompatibleGeometry,_fail_when_given_the_exact_shape_needed.patch
>
>
> Silently not indexing anything for a Shape is not okay. Users should get an
> Exception and then they can decide how to proceed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
