[ 
https://issues.apache.org/jira/browse/SOLR-3595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hoss Man updated SOLR-3595:
---------------------------

    Attachment: SOLR-3595.patch

My suggestion addressed the situation of trying to decalre the fieldType as 
multiValued, but did nothing to address fields & dynamic fields that were 
explicitly declared multiValued.

So in the attached patch i introduce a new method into the FieldType api called 
"checkSchemaField" which the SchemaField constructor uses to let the FieldType 
check the instance for errors that violate any invariants about hte field type. 
 the default impl is a NOOP and CurrencyField overrides this.

Would like someone to sanity check that this approach is a good idea (seems 
like it would definitely have other uses moving forward) otherwise i think it's 
feasible solution to the currency multivalued problem and we should get it in 
for 4.0
                
> Currency types do not support range queries when multiValued
> ------------------------------------------------------------
>
>                 Key: SOLR-3595
>                 URL: https://issues.apache.org/jira/browse/SOLR-3595
>             Project: Solr
>          Issue Type: Bug
>          Components: Schema and Analysis
>    Affects Versions: 4.0-ALPHA
>            Reporter: Erick Erickson
>            Assignee: Hoss Man
>            Priority: Minor
>              Labels: CurrencyField
>             Fix For: 4.0
>
>         Attachments: SOLR-3595.patch
>
>
> You can define the currency type as multiValued. However, if you do (and have 
> more than one value), range queries, at least, do not work. See the thread 
> titled "Filtering a query by range returning unexpected results".
> I'm not at all sure that currency type _should_ support multivalued. For 
> instance, how would one handle storing multiple values for a currency type in 
> different currencies (e.g. USD and EUR)? I don't know enough about the 
> internals to understand if it's possible, this JIRA is the result of a 
> question on the users list.
> If we decide that currency should _not_ support multiValued, it seems a check 
> at startup is in order on the "fail early, fail loudly" principle.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to